Skip to content

Conversation

@t-vi
Copy link
Contributor

@t-vi t-vi commented Nov 25, 2019

This starts a rocm codegen unittest for cross thread reduction.

I would like to add some testing to ensure some stuff we fixed keeps working. :)
This adds a test for cross thread reduction, which was broken before #4099 .

Naturally this will not be the only unit test, but I imagine that you will have feedback were to best put this.

@t-vi
Copy link
Contributor Author

t-vi commented Nov 25, 2019

@masahi if it's more about ROCm
Don't know who would want to comment on general setup of this type of test (I'd also want some on other items, like that we anticipate large workgroup sizes in our register use fixed in #4342 ).

Copy link
Member

@masahi masahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the location is fine. If you use topi, topi/tests is a good place.

@masahi masahi merged commit a44ac18 into apache:master Nov 25, 2019
zxy844288792 pushed a commit to zxy844288792/tvm that referenced this pull request Nov 26, 2019
yongwww pushed a commit to neo-ai/tvm that referenced this pull request Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants