Skip to content

Conversation

@masahi
Copy link
Member

@masahi masahi commented Dec 18, 2019

This is a prerequisite for #4536

cc @tqchen @jwfromm

@jwfromm
Copy link
Contributor

jwfromm commented Dec 18, 2019

Have you managed to get onnx.checker.check_model to work with ONNX 1.6? Whenever I've tried updating I encounter frequent segmentation faults. This is a known bug with 1.6 as seen in this Onnx issue. Assuming it still is around, we either have to drop use of the model checker (which is probably fine since it's not essential) or wait until they fix it in 1.7. If you want to go with the former, you should include the removal of the checker with this PR.

@masahi
Copy link
Member Author

masahi commented Dec 18, 2019

With ONNX v1.6, I do get segfault when importing both ONNX and PyTorch (seems to be the same issue as this one). If I remove PyTorch import, my test case in #4536, which uses onnxruntime (which in tern calls check_model) works fine. The following works for me too.

import onnx
model = onnx.load("resnet50.onnx") 
onnx.checker.check_model(model)

Doesn't the CI = green mean we are good to go with v1.6? Assuming the CI is updated with this PR and is running on v1.6 (not sure the correct way to update the CI env)

@tqchen
Copy link
Member

tqchen commented Dec 18, 2019

The CI is not directly updated when the docker get updated, see https://docs.tvm.ai/contribute/pull_request.html#ci-environment . Would be great if we can have tests to confirm things, i will also followup later this week.

@masahi
Copy link
Member Author

masahi commented Dec 18, 2019

Running tests/python/frontend/onnx/test_forward.py with the new CI should confirm whether ONNX v1.6 is in good state. Based on the discussion so far, it seems likely to crash.

@tqchen
Copy link
Member

tqchen commented Dec 19, 2019

I will suggest we wait until onnxrt 1.7 then as per suggested by @jwfromm @masahi shall we close for now?

@masahi
Copy link
Member Author

masahi commented Dec 19, 2019

Ok, no problem for me.

@masahi masahi closed this Dec 19, 2019
@masahi
Copy link
Member Author

masahi commented Dec 20, 2019

I've tested on an environment with ONNX 1.6 + PyTorch master build, I can run onnx/test_forward.py without any issue. I recommend updating our CI env to PyTorch 1.4 (which should be out soon) along with ONNX 1.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants