Fix onnx import bugs #4750
Merged
Fix onnx import bugs #4750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix onnx attributes of string type incorrect handling Merge symmetric padding of Conv to symmetric form
tqchen
added
status: need test case
jwfromm
approved these changes
Jan 21, 2020
Contributor
jwfromm
left a comment
jwfromm
left a comment
There was a problem hiding this comment.
LGTM once the CI issue is fixed. Thanks for fixing these!
Contributor
Author
Member
|
@kice it would be great if you can add a testcase that covers this corner case |
Member
|
ping @kice can you please add a few testcases? |
tqchen
removed
status: need review
status: need test case
tqchen
approved these changes
Feb 11, 2020
Member
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 26, 2020
* Fix onnx import bugs Fix onnx attributes of string type incorrect handling Merge symmetric padding of Conv to symmetric form * Only merge symmetric padding for conv2d
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 28, 2020
* Fix onnx import bugs Fix onnx attributes of string type incorrect handling Merge symmetric padding of Conv to symmetric form * Only merge symmetric padding for conv2d
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2020
* Fix onnx import bugs Fix onnx attributes of string type incorrect handling Merge symmetric padding of Conv to symmetric form * Only merge symmetric padding for conv2d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix onnx attributes of string type incorrect handling
Merge symmetric padding of Conv to symmetric form
ref: #4566 (comment)