[Build] Explicitly link to cublasLt if it exists #4776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Contributor
Author
|
Got it. In that case, I’ll update the logic to only link if it found the library.
…________________________________
From: masahi <notifications@github.com>
Sent: Friday, January 24, 2020 8:14 PM
To: apache/incubator-tvm
Cc: Jon Soifer; Mention
Subject: Re: [apache/incubator-tvm] [Build] Explicitly link to cublasLt (#4776)
@soiferj<https://github.com/soiferj> the CI is at CUDA 10.0, so it doesn't have cublaslt lib.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#4776>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AA2677Y4MA56HLVDNJ43LCLQ7OOBZANCNFSM4KLNCYOA>.
|
soiferj
changed the title
Contributor
Author
|
@masahi fixed. Would you mind taking another look? |
masahi
approved these changes
Jan 27, 2020
Member
|
thanks @soiferj |
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 26, 2020
* Explicitly link to cublasLt * Only link cublasLt if it's found Co-authored-by: Jon Soifer <jonso@microsoft.com>
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 28, 2020
* Explicitly link to cublasLt * Only link cublasLt if it's found Co-authored-by: Jon Soifer <jonso@microsoft.com>
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2020
* Explicitly link to cublasLt * Only link cublasLt if it's found Co-authored-by: Jon Soifer <jonso@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Windows build fails due to the linker not being able to find cublasLt functions. This change explicitly links to cublasLt.
@Laurawly @masahi @Hzfengsy would you be able to take a look?