Skip to content

Conversation

@tqchen
Copy link
Member

@tqchen tqchen commented Feb 12, 2020

for changes in #4837

cc @yzhliu @kparzysz-quic

Copy link
Contributor

@kparzysz-quic kparzysz-quic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@tqchen
Copy link
Member Author

tqchen commented Feb 14, 2020

cc @yzhliu can we try to add a regression test that covers the related functions?

@tqchen tqchen deleted the java branch March 16, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants