Skip to content

Conversation

@pingsutw
Copy link
Member

@pingsutw pingsutw commented Mar 1, 2020

When running dockerfile.demo_gpu, nvidia-smi command always not found.
Because we didn't declare DOCKER_IMAGE_NAME, so we always use docker instead of nvidia-docker
change DOCKER_IMAGE_NAME to CONTAINER_TYPE.

Copy link
Contributor

@cchung100m cchung100m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

LTGM, thanks to @pingsutw 👍

@pingsutw
Copy link
Member Author

pingsutw commented Mar 2, 2020

@cchung100m Thanks for the review.

@tqchen tqchen merged commit 7a06bbe into apache:master Mar 5, 2020
@tqchen tqchen mentioned this pull request Mar 9, 2020
5 tasks
@tqchen
Copy link
Member

tqchen commented Mar 9, 2020

This PR is among one of the PRs affected by the github squash commit bug. We take every contribution serious in the TVM community. The community has decided to use revert/redo approach to amend the contributions as per #5015

@pingsutw Please let us know if you would like us to revert the PR and resend the contribution. Thank you

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Apr 16, 2020
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants