[Realy] Replace UseDefaultCompiler with GetAttr #5088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comaniac
approved these changes
Mar 17, 2020
Contributor
comaniac
left a comment
comaniac
left a comment
There was a problem hiding this comment.
LGTM, although the semantic of !kCompiler.defined() is using TVM builtin codegen seems a bit weird.
tqchen
approved these changes
Mar 18, 2020
Member
|
Merge it in for now, see related discussion https://discuss.tvm.ai/t/target-and-attributes/6013/ |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Apr 16, 2020
zhiics
added a commit
to neo-ai/tvm
that referenced
this pull request
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #5045, we should remove
udeDefaultCompilerfromFunctionand useGetAttrinstead.cc @tqchen @comaniac @mbaret