Skip to content

Handle empty LLVMModule in GetFunction #5146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FrozenGene merged 1 commit into from
Mar 26, 2020
Merged

Handle empty LLVMModule in GetFunction #5146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/target/llvm/llvm_module.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,10 @@ class LLVMModuleNode final : public runtime::ModuleNode {
});
}
if (ee_ == nullptr) LazyInitJIT();

// This LLVMModule is empty and no function can be retrieved.
if (entry_func_.empty()) return nullptr;

std::lock_guard<std::mutex> lock(mutex_);
const std::string& fname = (name == runtime::symbol::tvm_module_main ?
entry_func_ : name);
Expand Down Expand Up @@ -318,6 +322,10 @@ class LLVMModuleNode final : public runtime::ModuleNode {
<< "Failed to initialize jit engine for " << mptr_->getTargetTriple();
ee_->runStaticConstructorsDestructors(false);
// setup context address.
// we will skip context setup if this LLVMModule is empty.
if (GetGlobalAddr(runtime::symbol::tvm_module_main) == 0)
return;

entry_func_ =
reinterpret_cast<const char*>(GetGlobalAddr(runtime::symbol::tvm_module_main));
if (void** ctx_addr = reinterpret_cast<void**>(
Expand All @@ -329,15 +337,15 @@ class LLVMModuleNode final : public runtime::ModuleNode {
});
}
// Get global address from execution engine.
uint64_t GetGlobalAddr(const std::string& name) {
uint64_t GetGlobalAddr(const std::string& name) const {
// first verifies if GV exists.
if (mptr_->getGlobalVariable(name) != nullptr) {
return ee_->getGlobalValueAddress(name);
} else {
return 0;
}
}
uint64_t GetFunctionAddr(const std::string& name) {
uint64_t GetFunctionAddr(const std::string& name) const {
// first verifies if GV exists.
if (mptr_->getFunction(name) != nullptr) {
return ee_->getFunctionAddress(name);
Expand Down