Skip to content

[TOPI] Improve get_valid_count and nms performance for CUDA #5339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tqchen merged 5 commits into from
Apr 15, 2020
Merged

[TOPI] Improve get_valid_count and nms performance for CUDA #5339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2ab3bd1
get_valid_count updated to have correct results
Laurawly Mar 26, 2020
4d85027
speedup nms
Laurawly Apr 7, 2020
6fce2c9
update nms
Laurawly Apr 14, 2020
5aa473e
revert back nms
Laurawly Apr 14, 2020
43f1575
recover one test for get_valid_count
Laurawly Apr 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion python/tvm/relay/frontend/mxnet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -842,7 +842,6 @@ def _mx_smooth_l1(inputs, attrs):

def _mx_deformable_convolution(inputs, attrs):
new_attrs = {}
assert attrs.get_bool("no_bias")
new_attrs["kernel_size"] = attrs.get_int_tuple("kernel")
new_attrs["strides"] = attrs.get_int_tuple("stride")
new_attrs["padding"] = attrs.get_int_tuple("pad")
Expand Down
3 changes: 3 additions & 0 deletions tests/python/relay/test_op_level5.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,9 @@ def verify_get_valid_counts(dshape, score_threshold, id_index, score_index):
intrp = relay.create_executor("debug", ctx=ctx, target=target)
out = intrp.evaluate(func)(np_data)
tvm.testing.assert_allclose(out[0].asnumpy(), np_out1, rtol=1e-3, atol=1e-04)
# get_valid_count for cuda doesn't do data rearrangement
if target == 'cuda':
return
tvm.testing.assert_allclose(out[1].asnumpy(), np_out2, rtol=1e-3, atol=1e-04)

verify_get_valid_counts((1, 2500, 6), 0, 0, 1)
Expand Down
Loading