[PYTHON] Improve equality wrapper #567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use `object.__eq__`(default object identity comparison) as default implementation of same_as. This should be OK since `EqualOp` and `NotEqualOp` are pure Python object, `object.__eq__` is sufficient.
Contributor
Author
|
I believe this is a transient failure, the same failure happened for another commit. Please retry the Jenkins build. |
tqchen
approved these changes
Oct 19, 2017
Contributor
Author
|
Interesting. Looking at the failure fixed by a retry, the mismatch rate is For my error, the mismatch rate is |
Member
|
@sxjscience can you check if argmin's impl have some potential issue? It could also due to ties and undefined behavior |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use
object.__eq__(default object identity comparison) as defaultimplementation of same_as. This should be OK since
EqualOpandNotEqualOpare pure Python object,object.__eq__is sufficient.