-
Notifications
You must be signed in to change notification settings - Fork 3.8k
µTVM CRT modifications for on-device RPC server #5921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
15a4ca0
Reorganize CRT into parts, public API, and add standalone build.
da7daab
Add TVMFuncRegistry, CRT test infrastructure, and tests.
4e2688c
Add TVMErrorf()
cf36cb3
[API_CHANGE] Integrate func registry into CRT.
f664bbf
Generalize arena-based memory manager.
4e1e1c8
lint
5c724c0
Fix git-clang-format arg parsing
a451506
add apache header
fa4f0e6
add mutable func registry tests
ea426db
Merge remote-tracking branch 'tvm/master' into utvm-crt-changes
ad1a72a
git-clang-format
9ce722f
fix more lint
5ec235e
Move memory_test to crttests.
c71fed9
fix tests
d0988e1
checkpoint
99b8b95
checkpoint
349c04c
bundle_deploy demo_static works
e7a251e
rm debug printf
773ae77
git-clang-format
d496349
Merge remote-tracking branch 'tvm/master' into utvm-crt-changes
1c69010
fix lint
408d820
add asf header
2a9d157
pylint
c19a346
update build configs for jenkins
008d92b
make regression compiler happy
099c254
fix build errors in regression GCC
622a66e
Merge remote-tracking branch 'tvm/master' into utvm-crt-changes
f0ee8a6
address comments
d1a7b42
git-clang-format
d2cc3b9
fix for 32-bit cpp regression
0595624
fix incorrect use of memcpy and tests for 32-bit
9acf614
clang-format
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why should we change this default behavior?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i changed this at first because llvm didn't work on my mac. then, I needed to keep it changed to handle --system-lib for now:
--system-lib is being handled using
python/tvm/micro/function_registry.py. in a follow-on I should be able to fold that in to C++ (I.e. as something like--system-lib --runtime=crt). is it ok to leave as c for this PR?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest keeping
llvm --system-lib, since we are targeting uTVM, not just mac :-)