[TIR][OP][API-CHANGE] Remove CallNode.call_type in favor of attribute. #5937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Followup of #5863 |
Member
Author
This was referenced Jun 26, 2020
tqchen
force-pushed
the
tir
branch
3 times, most recently
from
1892e0e to
8d112fb
Compare
This is a followup refactor for tir::Call. Now that we have switched call->name to call->op, the function effect property can be registered through the op itself, so we no longer need the call_type in the CallNode. - Introduce CallEffectKind to provide a more fine grained categorization of calls. - Introduce call_pure_extern and call_llvm_pure_intrin to allow us to indicate pure calls in those cases. - Migrate existing usecases to the new API.
ZihengJiang
approved these changes
Jun 27, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 30, 2020
apache#5937) This is a followup refactor for tir::Call. Now that we have switched call->name to call->op, the function effect property can be registered through the op itself, so we no longer need the call_type in the CallNode. - Introduce CallEffectKind to provide a more fine grained categorization of calls. - Introduce call_pure_extern and call_llvm_pure_intrin to allow us to indicate pure calls in those cases. - Migrate existing usecases to the new API.
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jul 2, 2020
apache#5937) This is a followup refactor for tir::Call. Now that we have switched call->name to call->op, the function effect property can be registered through the op itself, so we no longer need the call_type in the CallNode. - Introduce CallEffectKind to provide a more fine grained categorization of calls. - Introduce call_pure_extern and call_llvm_pure_intrin to allow us to indicate pure calls in those cases. - Migrate existing usecases to the new API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup refactor for tir::Call.
Now that we have switched call->name to call->op, the function effect property
can be registered through the op itself, so we no longer need the call_type in the CallNode.
allow us to indicate pure calls in those cases.
Upgrade Note