Refactor to expose MakeOp functions to C++ #6047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrookhart
changed the title
mbrookhart
force-pushed
the
mbrookhart/refactor_make_ops
branch
from
f565ccc to
c61ac20
Compare
zhiics
reviewed
Jul 13, 2020
mbrookhart
force-pushed
the
mbrookhart/refactor_make_ops
branch
from
632229f to
e64ee53
Compare
zhiics
approved these changes
Jul 14, 2020
Member
|
Thanks @mbrookhart |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jul 14, 2020
* Initial Refactor * add templated nn Make* functions * fix build typo * inline functions, fix unit tests
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jul 14, 2020
* Initial Refactor * add templated nn Make* functions * fix build typo * inline functions, fix unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zhiics The refactors we talked about in #6008. I'm pretty sure I didn't expose all of the Make* functions, but I think I got everything used in Pattern Util and Dyanamic-to-Static. Let me know what you think. Thanks!