Skip to content

Conversation

@comaniac
Copy link
Contributor

In #4520, I added a logic to skip the records with empty entities to avoid KeyError when altering depthwise ops. Due to the Relay op strategy, we won't let NCHWc use NCHW config anymore, so this logic is no longer required. In addition, the reason of removing this logic in this PR is to allow the records of vendor libraries to be loaded and selected by op strategy.

cc @icemelon9 @tqchen

Copy link
Member

@icemelon icemelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tqchen tqchen merged commit 79be003 into apache:master Jul 21, 2020
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Aug 26, 2020
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Aug 26, 2020
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Sep 2, 2020
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Sep 3, 2020
@comaniac comaniac deleted the load_empty_config branch October 19, 2020 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants