[Target] Target Tags, Composite Target and Unified Interface #6369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
approved these changes
Sep 2, 2020
Member
Author
junrushao
changed the title
junrushao
changed the title
tqchen
requested changes
Sep 6, 2020
Member
Author
comaniac
requested changes
Sep 8, 2020
comaniac
requested changes
Sep 9, 2020
Contributor
comaniac
left a comment
comaniac
left a comment
There was a problem hiding this comment.
Last bunch of comments.
Member
Author
Member
|
@junrushao1994 please rebase and resolve the conflicts |
Member
Author
|
Blocked by the windows built. Hot fix is here: #6434 |
* Add `set_attr_preprocessor` to TargetKind registry, which is used to pre-process attribute maps. * Use `set_attr_preprocessor` for NVPTX and ROCm backend to check and add mcpu and mtriple. * Add TargetTag registration and retrieval on C++ side and python side. Allow creation of Target using the tag name. * Unify target creation on C++ side, replace Target::Create and Target::FromConfig with the constructor. * Unify target creation on python side, deprecate tvm.target.create and encourage direct use of the constructor of tvm.target.Target instead. * Add initial support for composite target.
Member
Author
|
@tqchen CI is green. Would you like to take another look? Thanks! |
tqchen
approved these changes
Sep 10, 2020
tqchen
added
status: accepted
and removed
status: need review
status: need update
Member
|
Thanks @junrushao1994 @comaniac |
kevinthesun
pushed a commit
to kevinthesun/tvm
that referenced
this pull request
Sep 17, 2020
* Add `set_attr_preprocessor` to TargetKind registry, which is used to pre-process attribute maps. * Use `set_attr_preprocessor` for NVPTX and ROCm backend to check and add mcpu and mtriple. * Add TargetTag registration and retrieval on C++ side and python side. Allow creation of Target using the tag name. * Unify target creation on C++ side, replace Target::Create and Target::FromConfig with the constructor. * Unify target creation on python side, deprecate tvm.target.create and encourage direct use of the constructor of tvm.target.Target instead. * Add initial support for composite target.
kevinthesun
pushed a commit
to kevinthesun/tvm
that referenced
this pull request
Sep 18, 2020
* Add `set_attr_preprocessor` to TargetKind registry, which is used to pre-process attribute maps. * Use `set_attr_preprocessor` for NVPTX and ROCm backend to check and add mcpu and mtriple. * Add TargetTag registration and retrieval on C++ side and python side. Allow creation of Target using the tag name. * Unify target creation on C++ side, replace Target::Create and Target::FromConfig with the constructor. * Unify target creation on python side, deprecate tvm.target.create and encourage direct use of the constructor of tvm.target.Target instead. * Add initial support for composite target.
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 18, 2020
* Add `set_attr_preprocessor` to TargetKind registry, which is used to pre-process attribute maps. * Use `set_attr_preprocessor` for NVPTX and ROCm backend to check and add mcpu and mtriple. * Add TargetTag registration and retrieval on C++ side and python side. Allow creation of Target using the tag name. * Unify target creation on C++ side, replace Target::Create and Target::FromConfig with the constructor. * Unify target creation on python side, deprecate tvm.target.create and encourage direct use of the constructor of tvm.target.Target instead. * Add initial support for composite target.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set_attr_preprocessorto TargetKind registry, which is used to pre-process attribute maps. For exmaple, addmtripleautomatically.set_attr_preprocessorfor NVPTX and ROCm backend.Target::CreateandTarget::FromConfigwith the constructor.tvm.target.createand encourage direct use of the constructor oftvm.target.Targetinstead.