Skip to content

[Torch] Miscellaneous fix, enable some VM GPU tests #6418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tqchen merged 3 commits into from
Sep 8, 2020
Merged

[Torch] Miscellaneous fix, enable some VM GPU tests #6418

tqchen merged 3 commits into from
Sep 8, 2020

Conversation

@masahi
Copy link
Member

@masahi masahi commented Sep 7, 2020 •
edited
Loading

please review @siju-samuel @t-vi

@masahi masahi mentioned this pull request Sep 7, 2020
Closed
junrushao
junrushao approved these changes Sep 8, 2020
View reviewed changes
Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @masahi!

@t-vi
Copy link
Contributor

t-vi commented Sep 8, 2020

@masahi Thank you!

@tqchen tqchen merged commit 6f8e875 into apache:master Sep 8, 2020
@j-paulus j-paulus mentioned this pull request Sep 10, 2020
Closed
kevinthesun pushed a commit to kevinthesun/tvm that referenced this pull request Sep 17, 2020
@masahi @kevinthesun
[Torch] Miscellaneous fix, enable some VM GPU tests (apache#6418)
428e27e 
* fix strides conversion

* enable gpu target for some vm tests

* fix pooling stride None case

Co-authored-by: masa <masa@pop-os.localdomain>
kevinthesun pushed a commit to kevinthesun/tvm that referenced this pull request Sep 18, 2020
@masahi @kevinthesun
[Torch] Miscellaneous fix, enable some VM GPU tests (apache#6418)
e1468f2 
* fix strides conversion

* enable gpu target for some vm tests

* fix pooling stride None case

Co-authored-by: masa <masa@pop-os.localdomain>
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Sep 18, 2020
@masahi @trevor-m
[Torch] Miscellaneous fix, enable some VM GPU tests (apache#6418)
d96eb76 
* fix strides conversion

* enable gpu target for some vm tests

* fix pooling stride None case

Co-authored-by: masa <masa@pop-os.localdomain>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tqchen tqchen tqchen approved these changes

@junrushao junrushao junrushao approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: Strided N-D slicing in torch model ignoring the stride argument (strided_slice)

4 participants

@masahi @t-vi @tqchen @junrushao