Skip to content

Conversation

@junrushao
Copy link
Member

Recently I installed a spell checker in VSCode...

Copy link
Contributor

@electriclilies electriclilies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@jcf94 jcf94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. 😄

@junrushao
Copy link
Member Author

Let's wait for a few days before merging this PR, as I found some typos leftover

Copy link
Contributor

@leandron leandron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up. A couple more for your collection.

@tqchen
Copy link
Member

tqchen commented Sep 9, 2020

@junrushao1994 please incorporate @leandron 's comment then we can merge it in

@jroesch
Copy link
Member

jroesch commented Sep 11, 2020

should wait for #6448 before landing

@tqchen
Copy link
Member

tqchen commented Sep 11, 2020

@junrushao1994 please rebase and address @leandron 's comment

@junrushao
Copy link
Member Author

Should be good to go :-)

@junrushao
Copy link
Member Author

@tqchen @jcf94 Could you take another look? Thanks!

@tqchen tqchen merged commit d4919df into apache:master Sep 15, 2020
@tqchen
Copy link
Member

tqchen commented Sep 15, 2020

kevinthesun pushed a commit to kevinthesun/tvm that referenced this pull request Sep 17, 2020
kevinthesun pushed a commit to kevinthesun/tvm that referenced this pull request Sep 18, 2020
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants