[ONNX] Add support for GatherElements conversion #6446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siju-samuel
reviewed
Sep 11, 2020
Member
siju-samuel
left a comment
siju-samuel
left a comment
There was a problem hiding this comment.
LGTM, just remove the prints
masahi
force-pushed
the
torch-onnx-gatherelements
branch
from
f94b408 to
6cac63b
Compare
Member
Author
|
@siju-samuel please don't merge this PR until we first let #6448 in (I was asked by Jared to merge that PR as soon as possible before any other PR, to avoid conflict) |
masahi
force-pushed
the
torch-onnx-gatherelements
branch
from
6cac63b to
f744383
Compare
siju-samuel
reviewed
Sep 11, 2020
masahi
force-pushed
the
torch-onnx-gatherelements
branch
from
f744383 to
459adfa
Compare
Member
Author
|
@tqchen I've got "no space left on device" from CI. Is CI having a problem? |
masahi
force-pushed
the
torch-onnx-gatherelements
branch
from
459adfa to
c76317e
Compare
Contributor
|
I got the same error on another PR |
Member
|
@masahi @mbrookhart please retrigger, the space issue has been resolved |
masahi
force-pushed
the
torch-onnx-gatherelements
branch
from
c76317e to
37fb5c4
Compare
Member
Author
|
Thanks @siju-samuel @mbrookhart |
kevinthesun
pushed a commit
to kevinthesun/tvm
that referenced
this pull request
Sep 17, 2020
* support onnx GatherElements * remove print * run black Co-authored-by: masa <masa@pop-os.localdomain>
kevinthesun
pushed a commit
to kevinthesun/tvm
that referenced
this pull request
Sep 18, 2020
* support onnx GatherElements * remove print * run black Co-authored-by: masa <masa@pop-os.localdomain>
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 18, 2020
* support onnx GatherElements * remove print * run black Co-authored-by: masa <masa@pop-os.localdomain>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/onnx/onnx/blob/master/docs/Operators.md#GatherElements
This is required to convert decision trees from hummingbird to Relay.
please review @siju-samuel @jwfromm @mbrookhart