Skip to content

ROCm: use GcnArch for mcpu and ApiVersion to select code object version #6447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
masahi merged 1 commit into from
Sep 11, 2020
Merged

ROCm: use GcnArch for mcpu and ApiVersion to select code object version #6447

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions src/target/target_kind.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,19 +172,28 @@ Map<String, ObjectRef> UpdateROCmAttrs(Map<String, ObjectRef> attrs) {
arch = ExtractIntWithPrefix(mcpu, "gfx");
CHECK(arch != -1) << "ValueError: ROCm target gets an invalid GFX version: -mcpu=" << mcpu;
} else {
TVMRetValue version;
if (!DetectDeviceFlag({kDLROCM, 0}, runtime::kApiVersion, &version)) {
LOG(WARNING) << "Unable to detect ROCm version, default to \"-mcpu=gfx305\" instead";
arch = 305;
TVMRetValue val;
if (!DetectDeviceFlag({kDLROCM, 0}, runtime::kGcnArch, &val)) {
LOG(WARNING) << "Unable to detect ROCm compute arch, default to \"-mcpu=gfx900\" instead";
arch = 900;
} else {
arch = version.operator int();
arch = val.operator int();
}
attrs.Set("mcpu", String("gfx") + std::to_string(arch));
}
// Update -mattr before ROCm 3.5:
// Before ROCm 3.5 we needed code object v2, starting
// with 3.5 we need v3 (this argument disables v3)
if (arch < 305) {

TVMRetValue val;
int version;
if (!DetectDeviceFlag({kDLROCM, 0}, runtime::kApiVersion, &val)) {
LOG(WARNING) << "Unable to detect ROCm version, assuming >= 3.5";
version = 305;
} else {
version = val.operator int();
}
if (version < 305) {
Array<String> mattr;
if (attrs.count("mattr")) {
mattr = Downcast<Array<String>>(attrs.at("mattr"));
Expand Down