[ONNX] Update Slice op conversion to take strides into account, clean up tests #6467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrookhart
reviewed
Sep 13, 2020
Contributor
mbrookhart
left a comment
mbrookhart
left a comment
There was a problem hiding this comment.
I noticed this when I dynamic-ified strided slice in #6351 on Friday. This will conflict with that slightly, but I'm happy to deal with the conflicts in favor of the test improvements :)
I don't love the use of pytorch in the onnx tests, I'd really prefer fewer cross-framework testing dependencies.
Member
Author
|
@mbrookhart I realized, you would get some conflicts in |
added 2 commits
September 13, 2020 14:03
tqchen
approved these changes
Sep 13, 2020
Member
|
Thanks @masahi @mbrookhart ! |
kevinthesun
pushed a commit
to kevinthesun/tvm
that referenced
this pull request
Sep 17, 2020
… up tests (apache#6467) Co-authored-by: masa <masa@pop-os.localdomain>
kevinthesun
pushed a commit
to kevinthesun/tvm
that referenced
this pull request
Sep 18, 2020
… up tests (apache#6467) Co-authored-by: masa <masa@pop-os.localdomain>
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 18, 2020
… up tests (apache#6467) Co-authored-by: masa <masa@pop-os.localdomain>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6441
Also cleaned up test code in onnx a bit.
please review @siju-samuel @mbrookhart @jwfromm