[BYOC][ACL] Support add operation #6532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comaniac
requested changes
Sep 22, 2020
comaniac
changed the title
lhutton1
reviewed
Sep 23, 2020
d-smirnov
force-pushed
the
acl-add-operation
branch
4 times, most recently
from
cbfcbe0 to
2cc9ebe
Compare
comaniac
requested changes
Sep 28, 2020
d-smirnov
force-pushed
the
acl-add-operation
branch
from
2cc9ebe to
9574615
Compare
comaniac
approved these changes
Sep 28, 2020
Added support for an "add" operation implemented via ACL for fp32 and quantized uint8 data types
d-smirnov
force-pushed
the
acl-add-operation
branch
from
9574615 to
5733863
Compare
lhutton1
reviewed
Sep 29, 2020
Contributor
There was a problem hiding this comment.
Almost there :) just a couple of small things and a concern about a saturated test.
Could we also add support for add to the documentation here: https://github.com/apache/incubator-tvm/blob/master/docs/deploy/arm_compute_lib.rst
Contributor
|
@d-smirnov would you address the comments from @lhutton1 or? |
Contributor
|
Thanks @d-smirnov @lhutton1 |
comaniac
added
status: accepted
and removed
status: need update
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Oct 13, 2020
* [BYOC][ACL] Support add operation Added support for an "add" operation implemented via ACL for fp32 and quantized uint8 data types * Addressed lhutton1 comments * linter
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Oct 14, 2020
* [BYOC][ACL] Support add operation Added support for an "add" operation implemented via ACL for fp32 and quantized uint8 data types * Addressed lhutton1 comments * linter
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Oct 15, 2020
* [BYOC][ACL] Support add operation Added support for an "add" operation implemented via ACL for fp32 and quantized uint8 data types * Addressed lhutton1 comments * linter
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Oct 15, 2020
* [BYOC][ACL] Support add operation Added support for an "add" operation implemented via ACL for fp32 and quantized uint8 data types * Addressed lhutton1 comments * linter
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Oct 16, 2020
* [BYOC][ACL] Support add operation Added support for an "add" operation implemented via ACL for fp32 and quantized uint8 data types * Addressed lhutton1 comments * linter
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Oct 19, 2020
* [BYOC][ACL] Support add operation Added support for an "add" operation implemented via ACL for fp32 and quantized uint8 data types * Addressed lhutton1 comments * linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for an "add" operation implemented via ACL + unit test