Skip to content

Conversation

@comaniac
Copy link
Contributor

@comaniac comaniac commented Sep 25, 2020

After #6391, we require USE_RANDOM to be on during the tuning. However, setting USE_RANDOM ON in cmake/config.cmake doesn't really turn it on by default.

This PR makes CMakefile and config.cmake consistent. Specifically, turn on USE_RANDOM and USE_SORT in CMakefile as in config.cmake; remove unnecessary configs in install_tvm_xx.sh.

cc @FrozenGene, @tqchen

@comaniac comaniac requested a review from FrozenGene September 25, 2020 23:15
@FrozenGene
Copy link
Member

FrozenGene commented Sep 25, 2020 via email

@comaniac comaniac requested a review from tqchen September 25, 2020 23:22
@comaniac
Copy link
Contributor Author

comaniac commented Sep 25, 2020

It's fine if users directly copy cmake/config.cmake to build. However, as the usage in the docker images, some users prefer to create a simple config.cmake that only overrides the values against CMakefile. In my personal case, my config.cmake doesn't have USE_RANDOM and I expected it to be ON by referring to cmake/config.cmake, but it doesn't work as expected, so does USE_SORT.

@FrozenGene
Copy link
Member

ok. Thanks for explaining.

@tqchen tqchen merged commit 9555c99 into apache:master Sep 26, 2020
@comaniac comaniac deleted the turn_on_random branch September 26, 2020 16:31
TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Oct 13, 2020
TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Oct 14, 2020
TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Oct 15, 2020
TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Oct 16, 2020
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Oct 19, 2020
apivovarov pushed a commit to neo-ai/tvm that referenced this pull request Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants