-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[AutoTVM][Ansor] Turn on USE_RANDOM by default #6562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b6f6db0 to
5a22d76
Compare
Member
|
Thanks Cody. Could you explain a little bit why cmake/config.cmake doesn’t turn it on by default? As USE_SORT uses this way too------------------ Original ------------------From: Cody Yu <notifications@github.com>Date: Sat,Sep 26,2020 7:16 AMTo: apache/incubator-tvm <incubator-tvm@noreply.github.com>Cc: Zhao Wu <zhaowu@apache.org>, Mention <mention@noreply.github.com>Subject: Re: [apache/incubator-tvm] [AutoTVM][Ansor] Turn on USE_RANDOM by default (#6562)After #6391, we require USE_RANDOM to be on during the tuning. However, setting USE_RANDOM ON in cmake/config.cmake doesn't really turn it on by default.
cc @FrozenGene
You can view, comment on, or merge this pull request online at:
#6562
Commit Summary
Turn on USE_RANDOM by default
File Changes
M
CMakeLists.txt
(2)
Patch Links:
https://github.com/apache/incubator-tvm/pull/6562.patch
https://github.com/apache/incubator-tvm/pull/6562.diff
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.
|
Contributor
Author
|
It's fine if users directly copy |
Member
|
ok. Thanks for explaining. |
FrozenGene
approved these changes
Sep 25, 2020
tqchen
approved these changes
Sep 26, 2020
junrushao
approved these changes
Sep 26, 2020
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Oct 13, 2020
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Oct 14, 2020
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Oct 15, 2020
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Oct 16, 2020
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Oct 19, 2020
apivovarov
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #6391, we require
USE_RANDOMto be on during the tuning. However, settingUSE_RANDOM ONincmake/config.cmakedoesn't really turn it on by default.This PR makes CMakefile and config.cmake consistent. Specifically, turn on
USE_RANDOMandUSE_SORTin CMakefile as in config.cmake; remove unnecessary configs ininstall_tvm_xx.sh.cc @FrozenGene, @tqchen