[Rust][Diagnostics] Add initial boilerplate for Rust diagnostic interface. #6656

jroesch · 2020-10-09T22:02:37Z

This PR exposes new diagnostics to Rust so we can reuse the better libraries for diagnostics rendering via Rust.

jroesch · 2020-10-09T22:03:00Z

cc @gussmith23 and @mwillsey

rust/compiler-ext/Cargo.toml

rust/compiler-ext/src/lib.rs

rust/tvm/src/ir/diagnostics/codespan.rs

cmake/modules/RustExt.cmake

rust/tvm/src/ir/diagnostics/mod.rs

rust/tvm/src/ir/span.rs

cmake/modules/RustExt.cmake

CMakeLists.txt

Co-authored-by: Robert Kimball <bobkimball@gmail.com>

jroesch · 2020-10-26T06:46:37Z

I think this one is now ready to roll.

cmake/modules/LLVM.cmake

cmake/modules/RustExt.cmake

Co-authored-by: Tristan Konolige <tristan.konolige@gmail.com>

rust/compiler-ext/Cargo.toml

adelbertc · 2020-10-31T20:24:18Z

rust/tvm-rt/src/array.rs

+
+    fn next(&mut self) -> Option<Self::Item> {
+        if self.pos < self.size {
+            let item = self.array.get(self.pos).expect("should not fail");


Even though exceptional, better error message here than "should not fail"

rust/tvm-rt/src/function.rs

rust/tvm/src/bin/tyck.rs

adelbertc · 2020-10-31T20:35:32Z

rust/tvm/src/ir/diagnostics/codespan.rs

+}
+
+/// A mapping for all files in a source map to byte ranges.
+struct SpanToByteRange {


Is this a place where we could integrating like tracing-style spans? (looking for PR ideas)

adelbertc · 2020-10-31T20:37:52Z

rust/tvm/src/ir/module.rs


+#[derive(Error, Debug)]
+pub enum Error {
+    #[error("{0}")]


Do we also want to use #[source] for the errors?

This kind of stuff would be good follow up work imo.

…face. (apache#6656) * Add initial boilerplate for Rust diagnostic interface. * Codespan example almost working * WIP * Hacking on Rust inside of TVM * Borrow code from Egg * Update CMake and delete old API * Fix Linux build * Clean up exporting to show off new diagnostics * Improve Rust bindings * Fix calling * Fix * Rust Diagnostics work * Remove type checker * Format and cleanup * Fix the extension code * More cleanup * Fix some CR * Add docs and address feedback * WIP more improvments * Update cmake/modules/RustExt.cmake Co-authored-by: Robert Kimball <bobkimball@gmail.com> * Update rust/tvm/src/ir/diagnostics/mod.rs Co-authored-by: Robert Kimball <bobkimball@gmail.com> * Clean up PR * Format all * Remove dead comment * Code review comments and apache headers * Purge test file * Update cmake/modules/LLVM.cmake Co-authored-by: Tristan Konolige <tristan.konolige@gmail.com> * Format Rust * Add TK's suggestion * More CR and cleanup * Fix tyck line * Format Co-authored-by: Robert Kimball <bobkimball@gmail.com> Co-authored-by: Tristan Konolige <tristan.konolige@gmail.com>

jroesch changed the title ~~[Rust][Diagnostics] Add initial boilerplate for Rust diagnostic interface.~~ [Rust][Diagnostics][WIP] Add initial boilerplate for Rust diagnostic interface. Oct 9, 2020

tqchen changed the base branch from master to main October 11, 2020 18:16

jroesch force-pushed the rust-diag branch from 4035009 to 436ab62 Compare October 16, 2020 21:17

jroesch changed the title ~~[Rust][Diagnostics][WIP] Add initial boilerplate for Rust diagnostic interface.~~ [Rust][Diagnostics] Add initial boilerplate for Rust diagnostic interface. Oct 16, 2020

jroesch commented Oct 16, 2020

View reviewed changes

rust/compiler-ext/Cargo.toml Outdated Show resolved Hide resolved

tkonolige reviewed Oct 16, 2020

View reviewed changes

rust/compiler-ext/src/lib.rs Outdated Show resolved Hide resolved

tkonolige reviewed Oct 16, 2020

View reviewed changes

rust/tvm/src/ir/diagnostics/codespan.rs Show resolved Hide resolved

rkimball suggested changes Oct 16, 2020

View reviewed changes

cmake/modules/RustExt.cmake Outdated Show resolved Hide resolved

jroesch and others added 17 commits October 19, 2020 23:01

Add initial boilerplate for Rust diagnostic interface.

e6f992e

Codespan example almost working

4fe35b0

WIP

dfacf9e

Hacking on Rust inside of TVM

e827660

Borrow code from Egg

a1a4f3e

Update CMake and delete old API

52177cc

Fix Linux build

c5b4061

Clean up exporting to show off new diagnostics

29754ae

Improve Rust bindings

39c90da

Fix calling

c1b994c

Fix

7ea0c34

Rust Diagnostics work

46c46ad

Remove type checker

8f219a6

Format and cleanup

6f28414

Fix the extension code

af518e1

More cleanup

beb8f1c

Fix some CR

657c708

jroesch force-pushed the rust-diag branch from 22ec391 to 657c708 Compare October 20, 2020 06:02

jroesch added 2 commits October 20, 2020 15:06

Add docs and address feedback

06cdc47

WIP more improvments

db6b355

rkimball suggested changes Oct 22, 2020

View reviewed changes

rust/tvm/src/ir/diagnostics/mod.rs Outdated Show resolved Hide resolved

rust/tvm/src/ir/span.rs Outdated Show resolved Hide resolved

cmake/modules/RustExt.cmake Outdated Show resolved Hide resolved

CMakeLists.txt Outdated Show resolved Hide resolved

jroesch and others added 7 commits October 24, 2020 00:28

Update cmake/modules/RustExt.cmake

9aa1a09

Co-authored-by: Robert Kimball <bobkimball@gmail.com>

Update rust/tvm/src/ir/diagnostics/mod.rs

7e038e0

Co-authored-by: Robert Kimball <bobkimball@gmail.com>

Clean up PR

9a0e727

Format all

d086193

Remove dead comment

62f3e39

Code review comments and apache headers

0b5645e

Purge test file

2f778db

rkimball approved these changes Oct 26, 2020

View reviewed changes

tkonolige reviewed Oct 26, 2020

View reviewed changes

cmake/modules/LLVM.cmake Show resolved Hide resolved

tkonolige reviewed Oct 26, 2020

View reviewed changes

cmake/modules/RustExt.cmake Outdated Show resolved Hide resolved

jroesch and others added 3 commits October 30, 2020 13:51

Update cmake/modules/LLVM.cmake

e8fd9a5

Co-authored-by: Tristan Konolige <tristan.konolige@gmail.com>

Format Rust

e92adcc

Add TK's suggestion

5731a60

adelbertc reviewed Oct 31, 2020

View reviewed changes

jroesch added 3 commits October 31, 2020 15:06

More CR and cleanup

0065966

Fix tyck line

5f2ad03

Format

9700d81

adelbertc approved these changes Nov 1, 2020

View reviewed changes

junrushao approved these changes Nov 2, 2020

View reviewed changes

junrushao merged commit 883954e into apache:main Nov 2, 2020

jroesch deleted the rust-diag branch February 4, 2021 04:42

junrushao mentioned this pull request Nov 1, 2021

Apache TVM v0.8 Release Note Candidate #9416

Closed

[Rust][Diagnostics] Add initial boilerplate for Rust diagnostic interface. #6656

[Rust][Diagnostics] Add initial boilerplate for Rust diagnostic interface. #6656

Uh oh!

Conversation

jroesch commented Oct 9, 2020

Uh oh!

jroesch commented Oct 9, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jroesch commented Oct 26, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

adelbertc Oct 31, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

adelbertc Oct 31, 2020

Choose a reason for hiding this comment

Uh oh!

adelbertc Oct 31, 2020

Choose a reason for hiding this comment

Uh oh!

jroesch Oct 31, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants