[Relay] Change some passes to mix mode #6695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lixiaoquan
force-pushed
the
mixed
branch
2 times, most recently
from
3da9dd1 to
7c3e75e
Compare
mbrookhart
approved these changes
Oct 16, 2020
Contributor
mbrookhart
left a comment
mbrookhart
left a comment
There was a problem hiding this comment.
Minor nitpick on constant folding, but it's definitely not an issue. Overall, looks great! Thanks for doing this!
| } | ||
|
|
||
| Expr VisitExpr_(const CallNode* call) final { | ||
| Expr Rewrite_(const CallNode* call, const Expr& post) final { |
Contributor
There was a problem hiding this comment.
(nitpick) You could locally rename this argument from post to res, and then you wouldn't need most of the other changes in the function?
Contributor
tqchen
approved these changes
Oct 16, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Oct 29, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 2, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 4, 2020
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mbrookhart Could you please take a look?