More flexible conv2d_NCHWc_int8 generic operator. #6714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giuseros
reviewed
Oct 29, 2020
Contributor
|
Thanks for the explanation and for the pointers @cbalint13 ! This LGTM |
Contributor
Author
@giuseros , Thank you very much ! |
giuseros
approved these changes
Nov 5, 2020
Contributor
giuseros
left a comment
giuseros
left a comment
There was a problem hiding this comment.
I didn't know I had the possibility to approve PRs without being a "reviewer". Apparently yes :)
vinx13
approved these changes
Nov 7, 2020
Member
|
@cbalint13 could you try restarting the CI? |
Contributor
Author
@vinx13 , done, passed. Thank You ! |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 2, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 4, 2020
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR enable flexible parametrizations for
conv2d_NCHWc_int8()int terms ofint32_lanesandint8_elements.Goal:
conv2d_NCHWc_int8()to be called with any custom values ofint32_lanesandint8_elementsChanges:
n_elems(default=4) optional parameter instead of staticn_elems = 4hardcode.int32_lane < int8_num_elementstoo.@anijain2305 @zhiics @vinx13 @ZihengJiang please help me with the review,
Thank You !