[FFI][BUGFIX] Fix memory leak when Pac callback argument is NDArray #6744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Matthew Brookhart <mbrookhart@octoml.ai>
Member
Author
|
kudos to @mbrookhart who uncovered this bug initially |
Member
Author
mbrookhart
approved these changes
Oct 23, 2020
Contributor
mbrookhart
left a comment
mbrookhart
left a comment
There was a problem hiding this comment.
Thanks for the fast turn arround! This fixes several subtle bugs I've been dealing with lately.
junrushao
approved these changes
Oct 23, 2020
Member
Author
junrushao
reviewed
Oct 23, 2020
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Oct 29, 2020
…pache#6744) * [FFI][BUGFIX] Fix leak when Packed callback arg is ndarray. Co-authored-by: Matthew Brookhart <mbrookhart@octoml.ai> * Fix for rust ts and jvm * Update rust/tvm-rt/src/to_function.rs Co-authored-by: Junru Shao <junrushao1994@gmail.com> Co-authored-by: Matthew Brookhart <mbrookhart@octoml.ai> Co-authored-by: Junru Shao <junrushao1994@gmail.com>
tqchen
added a commit
to tqchen/tvm
that referenced
this pull request
Nov 2, 2020
…pache#6744) * [FFI][BUGFIX] Fix leak when Packed callback arg is ndarray. Co-authored-by: Matthew Brookhart <mbrookhart@octoml.ai> * Fix for rust ts and jvm * Update rust/tvm-rt/src/to_function.rs Co-authored-by: Junru Shao <junrushao1994@gmail.com> Co-authored-by: Matthew Brookhart <mbrookhart@octoml.ai> Co-authored-by: Junru Shao <junrushao1994@gmail.com>
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 2, 2020
…pache#6744) * [FFI][BUGFIX] Fix leak when Packed callback arg is ndarray. Co-authored-by: Matthew Brookhart <mbrookhart@octoml.ai> * Fix for rust ts and jvm * Update rust/tvm-rt/src/to_function.rs Co-authored-by: Junru Shao <junrushao1994@gmail.com> Co-authored-by: Matthew Brookhart <mbrookhart@octoml.ai> Co-authored-by: Junru Shao <junrushao1994@gmail.com>
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 4, 2020
…pache#6744) * [FFI][BUGFIX] Fix leak when Packed callback arg is ndarray. Co-authored-by: Matthew Brookhart <mbrookhart@octoml.ai> * Fix for rust ts and jvm * Update rust/tvm-rt/src/to_function.rs Co-authored-by: Junru Shao <junrushao1994@gmail.com> Co-authored-by: Matthew Brookhart <mbrookhart@octoml.ai> Co-authored-by: Junru Shao <junrushao1994@gmail.com>
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Dec 4, 2020
…pache#6744) * [FFI][BUGFIX] Fix leak when Packed callback arg is ndarray. Co-authored-by: Matthew Brookhart <mbrookhart@octoml.ai> * Fix for rust ts and jvm * Update rust/tvm-rt/src/to_function.rs Co-authored-by: Junru Shao <junrushao1994@gmail.com> Co-authored-by: Matthew Brookhart <mbrookhart@octoml.ai> Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Matthew Brookhart mbrookhart@octoml.ai