Skip to content

Conversation

@rohanmukh
Copy link
Contributor

This arises insed ManifestAllocPass inside relay.vm.compile

Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.

This arises insed ManifestAllocPass inside relay.vm.compile
@anijain2305 anijain2305 requested a review from icemelon October 27, 2020 23:31
@anijain2305
Copy link
Contributor

@icemelon9 Can you PTAL?

@anijain2305 anijain2305 changed the title Changes in CheckReshapeOnly to support TupleTypes as input [ManifestAlloc] Handle TupleType inputs in CheckReshapeOnly Oct 27, 2020
@jroesch
Copy link
Member

jroesch commented Oct 28, 2020

cc @altanh @MarisaKirisame

y_data = np.random.uniform(size=y_shape).astype("float32")

for tgt, ctx in tvm.testing.enabled_targets():
res = veval(f, (x_data, y_data))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use tgt and ctx here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @altanh for pointing this. I resolved this.

Copy link
Member

@icemelon icemelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anijain2305 anijain2305 merged commit 4c4888b into apache:main Oct 28, 2020
@anijain2305
Copy link
Contributor

Thanks @rohanmukh @altanh @icemelon9
This is merged

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Oct 29, 2020
)

* Changes in CheckReshapeOnly to support TupleTypes as input

This arises insed ManifestAllocPass inside relay.vm.compile

* [ManifestAlloc] Handle TupleType inputs in CheckReshapeOnly
TusharKanekiDey pushed a commit to neo-ai/tvm that referenced this pull request Nov 3, 2020
)

* Changes in CheckReshapeOnly to support TupleTypes as input

This arises insed ManifestAllocPass inside relay.vm.compile

* [ManifestAlloc] Handle TupleType inputs in CheckReshapeOnly
codeislife99 pushed a commit to codeislife99/incubator-tvm that referenced this pull request Nov 20, 2020
)

* Changes in CheckReshapeOnly to support TupleTypes as input

This arises insed ManifestAllocPass inside relay.vm.compile

* [ManifestAlloc] Handle TupleType inputs in CheckReshapeOnly
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Dec 2, 2020
)

* Changes in CheckReshapeOnly to support TupleTypes as input

This arises insed ManifestAllocPass inside relay.vm.compile

* [ManifestAlloc] Handle TupleType inputs in CheckReshapeOnly
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Dec 4, 2020
)

* Changes in CheckReshapeOnly to support TupleTypes as input

This arises insed ManifestAllocPass inside relay.vm.compile

* [ManifestAlloc] Handle TupleType inputs in CheckReshapeOnly
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Dec 4, 2020
)

* Changes in CheckReshapeOnly to support TupleTypes as input

This arises insed ManifestAllocPass inside relay.vm.compile

* [ManifestAlloc] Handle TupleType inputs in CheckReshapeOnly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants