Skip to content

[Runtime][RelayVM] Explicitly use new to avoid exit-time destruction of global state #6938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tqchen merged 1 commit into from
Nov 19, 2020
Merged

[Runtime][RelayVM] Explicitly use new to avoid exit-time destruction of global state #6938

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/runtime/vm/memory_manager.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,10 @@ NDArray StorageObj::AllocNDArray(size_t offset, std::vector<int64_t> shape, DLDa
}

MemoryManager* MemoryManager::Global() {
static MemoryManager memory_manager;
return &memory_manager;
// NOTE: explicitly use new to avoid exit-time destruction of global state
// Global state will be recycled by OS as the process exits.
static auto* inst = new MemoryManager();
return inst;
}

Allocator* MemoryManager::GetOrCreateAllocator(TVMContext ctx, AllocatorType type) {
Expand Down