[AutoScheduler] Task scheduler callbacks #6945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merrymercy
requested changes
Nov 22, 2020
Member
merrymercy
left a comment
merrymercy
left a comment
There was a problem hiding this comment.
Some comments on the naming and API
Contributor
Author
|
@merrymercy @FrozenGene PTAL. |
merrymercy
reviewed
Nov 23, 2020
merrymercy
approved these changes
Nov 23, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 2, 2020
* [AutoScheduler] Task scheduler callbacks * docstring * address comments * Delete the explaination of callback in the tutorial * fix Co-authored-by: Lianmin Zheng <lianminzheng@gmail.com>
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 4, 2020
* [AutoScheduler] Task scheduler callbacks * docstring * address comments * Delete the explaination of callback in the tutorial * fix Co-authored-by: Lianmin Zheng <lianminzheng@gmail.com>
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Dec 4, 2020
* [AutoScheduler] Task scheduler callbacks * docstring * address comments * Delete the explaination of callback in the tutorial * fix Co-authored-by: Lianmin Zheng <lianminzheng@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that it would be useful to log how the total latency is improved during the tuning process, especially for the case of using task scheduler. Since this requirement could be case by case, I tried to make a callback mechanism for task scheduler, and changed the existing
_print_table_infoto one callback. This is not necessary to be the final version. Suggestions and comments about where to call the callbacks and what arguments they should accept are welcome.cc @merrymercy @jcf94 @FrozenGene @minminsun