Skip to content

[TFLite] Bugfix - ensure pad calcalution to be in int32 #7009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anijain2305 wants to merge 2 commits into from
Closed

[TFLite] Bugfix - ensure pad calcalution to be in int32 #7009

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2146f36
[TFLite] Bugfix - ensure pad calcalution to be in int32
Dec 1, 2020
676b879
Empty
Dec 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/tvm/relay/frontend/tflite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3210,7 +3210,7 @@ def get_pad_value(data, kernel, stride):
"""

out = int(math.ceil(float(data) / float(stride)))
pad = max(0, (out - 1) * stride + kernel - data)
pad = max(0, (out - 1) * int(stride) + int(kernel) - int(data))
Copy link
Contributor

@kevinthesun kevinthesun Dec 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to somehow test the compilation for skylake/cascadelake target?

Copy link
Contributor

@giuseros giuseros Dec 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, do we know why this fails with int64? AFAIU from your RFC: https://discuss.tvm.apache.org/t/int64-vs-int32-dtype-error/8555 this used to work before.

pad_before = pad // 2
pad_after = pad - pad_before
return pad_before, pad_after
Expand Down
2 changes: 2 additions & 0 deletions src/printer/relay_text_printer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,8 @@ Doc RelayTextPrinter::ScalarLiteral(DataType dtype, const T& value) {
std::ostringstream os;
if (dtype == DataType::Int(32)) {
os << value;
} else if (dtype == DataType::Int(64)) {
os << value << "i64";
} else if (dtype == DataType::Float(32)) {
os << value << 'f';
} else if (dtype == DataType::Float(64)) {
Expand Down