#7058 [Tutorial] Import errors in deploy_detection.py and deploy_classification.py #7059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 8, 2020 16:04
Changed import paths
changed import paths and stop layer id
Member
tmoreau89
approved these changes
Dec 8, 2020
Contributor
tmoreau89
left a comment
tmoreau89
left a comment
There was a problem hiding this comment.
Thank you for catching these bugs, LGTM
vegaluisjose
approved these changes
Dec 8, 2020
added 2 commits
December 9, 2020 08:35
Set working directory to TVM base.
Set working directory to TVM base. Changed layer id in comment to 186.
liangfu
requested changes
Dec 9, 2020
Member
liangfu
left a comment
liangfu
left a comment
There was a problem hiding this comment.
Thanks for catching the bug. Please resolve the CI errors before we could merge the PR.
added 2 commits
December 9, 2020 14:06
Reversed changes in import path. Imports working as expected.
Imports working as expected.
liangfu
approved these changes
Dec 10, 2020
Member
liangfu
left a comment
liangfu
left a comment
There was a problem hiding this comment.
Thanks for the update @fprotopapa. The changes look good.
| from tvm.relay.testing import yolo_detection, darknet | ||
| from tvm.relay.testing.darknet import __darknetffi__ | ||
| from tvm.contrib import graph_runtime, graph_runtime, util | ||
| from tvm.contrib import graph_runtime, graph_runtime, utils |
Member
There was a problem hiding this comment.
Do you mind remove the duplicated graph_runtime here as well?
Contributor
Author
There was a problem hiding this comment.
Duplicated import is removed.
Duplicated graph_runtime import removed.
Contributor
|
Thank you @fprotopapa and @liangfu and @vegaluisjose for reviewing the PR! |
|
Thanks for fixing it! I've run into this bug too on Dec 10 01:26:05 2020 version code. After this fix, I am using the newest version code of 'Fri Jan 15 07:59:28 2021', there is another error when running Did your |
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Jan 20, 2021
…y_classification.py (apache#7059) * Update deploy_classification.py Changed import paths * Update deploy_detection.py changed import paths and stop layer id * Update deploy_classification.py Set working directory to TVM base. * Update deploy_detection.py Set working directory to TVM base. Changed layer id in comment to 186. * reverse changes in deploy_classification.py Reversed changes in import path. Imports working as expected. * Reverse change in import paths Imports working as expected. * Update deploy_detection.py Duplicated graph_runtime import removed.
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jan 21, 2021
…y_classification.py (apache#7059) * Update deploy_classification.py Changed import paths * Update deploy_detection.py changed import paths and stop layer id * Update deploy_classification.py Set working directory to TVM base. * Update deploy_detection.py Set working directory to TVM base. Changed layer id in comment to 186. * reverse changes in deploy_classification.py Reversed changes in import path. Imports working as expected. * Reverse change in import paths Imports working as expected. * Update deploy_detection.py Duplicated graph_runtime import removed.
electriclilies
pushed a commit
to electriclilies/tvm
that referenced
this pull request
Feb 18, 2021
…y_classification.py (apache#7059) * Update deploy_classification.py Changed import paths * Update deploy_detection.py changed import paths and stop layer id * Update deploy_classification.py Set working directory to TVM base. * Update deploy_detection.py Set working directory to TVM base. Changed layer id in comment to 186. * reverse changes in deploy_classification.py Reversed changes in import path. Imports working as expected. * Reverse change in import paths Imports working as expected. * Update deploy_detection.py Duplicated graph_runtime import removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into import errors while following the
VTA tutorial for 'Deploy Pretrained Vision Model from MxNet on VTA'under Ubuntu 18.04.5 LTS and Docker images created with Dockerfile.ci_cpu. Scripts launched from tvm base directory.File: tvm/vta/tutorials/frontend/deploy_classification.pyIn line 59 to 61:
import vtafrom vta.testing import simulator
from vta.top import graph_pack
Import paths have changed and function call for graph_pack in line 181.Changed to:import vtafrom vta.python.vta.testing import simulator
from vta.python.vta.top import graphpack as graph_pack
from vta.python import vta
and in line 181relay_prog = graph_pack.graph_pack(Issue in file tvm/vta/tutorials/frontend/legacy/deploy_detection.py
Line 61:
Changed to:
Also layer id for stop layer 'cast' changed from 185 to 186 in line 126 and in the comment.