Fixes for using Python APIs from Rust. #7085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jroesch
force-pushed
the
fix-for-therml
branch
2 times, most recently
from
537bc18 to
0eb6aa5
Compare
Member
Author
|
cc @hypercubestart @binarybana @imalsogreg updated this |
imalsogreg
reviewed
Feb 4, 2021
imalsogreg
reviewed
Feb 4, 2021
imalsogreg
reviewed
Feb 4, 2021
jroesch
changed the title
jroesch
force-pushed
the
fix-for-therml
branch
2 times, most recently
from
56772fa to
ce92b07
Compare
This commit also updates the docs to remove outdated information.
jroesch
force-pushed
the
fix-for-therml
branch
from
ce92b07 to
08fddd3
Compare
Contributor
hypercubestart
left a comment
hypercubestart
left a comment
There was a problem hiding this comment.
does this test pass now?
| let sys = py.import("tvm")?; | ||
| let version: String = sys.get("__version__")?.extract()?; | ||
| // py.run(TVMC_CODE, None, None)?; | ||
| let imported_mod = import_python(py, "tvm")?; |
Contributor
There was a problem hiding this comment.
oops forgot to add the comment.
theres an ignored test test_run in this file, if everything works the ignore attribute should be removed
Member
Author
There was a problem hiding this comment.
This test seems to pass on most platforms but not CI, going to keep disabled until I can be sure it won't cause CI flakiness.
Contributor
There was a problem hiding this comment.
ok, its strange to me that loading tvm into rust is flaky though
Member
|
There seems to be a problem with scipy in the CI @jroesch ? |
| /// Wrapper around TVM module handle which contains an entry function. | ||
| /// The entry function can be applied to an imported module through [`entry_func`]. | ||
| /// | ||
| /// [`entry_func`]:struct.Module.html#method.entry_func |
Contributor
There was a problem hiding this comment.
is this comment still true?
| let sys = py.import("tvm")?; | ||
| let version: String = sys.get("__version__")?.extract()?; | ||
| // py.run(TVMC_CODE, None, None)?; | ||
| let imported_mod = import_python(py, "tvm")?; |
Contributor
There was a problem hiding this comment.
ok, its strange to me that loading tvm into rust is flaky though
| /// | ||
| /// * `config` - The configuration for the compiler. | ||
| /// * `module` - The IRModule to compile. | ||
| pub fn compile_module(config: CompilerConfig, module: IRModule) -> Result<RtModule, Error> { |
Contributor
There was a problem hiding this comment.
is there a test for this?
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
* Rewrite the Rust Module API and change some imports causing crashes. This commit also updates the docs to remove outdated information. * Renable Python test and remove warnings * Python test still flaky * Fix broken module test * Fix broken test * Reset test file
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
* Rewrite the Rust Module API and change some imports causing crashes. This commit also updates the docs to remove outdated information. * Renable Python test and remove warnings * Python test still flaky * Fix broken module test * Fix broken test * Reset test file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @hypercubestart this is a bigger PR to fix the current bindings and enable calling them with the Python code, but it needs a bit of cleanup, there are some changes that I used to debug segfaults.