Skip to content

Conversation

@jwfromm
Copy link
Contributor

@jwfromm jwfromm commented Dec 10, 2020

This little PR adds support for the ONNX Softplus operator.

@jwfromm
Copy link
Contributor Author

jwfromm commented Dec 10, 2020

@masahi @CircleSpin can you guys take a look at this PR?

Copy link
Contributor

@CircleSpin CircleSpin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masahi masahi merged commit ac25b4b into apache:main Dec 11, 2020
@masahi
Copy link
Member

masahi commented Dec 11, 2020

thanks @jwfromm (and welcome @CircleSpin !)

insop added a commit to insop/incubator-tvm that referenced this pull request Jan 1, 2021
- `Softplus` is added in 12/10/2020 from this apache#7089
- However, I see that there were `SoftPlus` (not the P is in capital) was already in.
According to [Onnx spec](https://github.com/onnx/onnx/blob/master/docs/Operators.md), it is `Softplus` not `SoftPlus`.
masahi pushed a commit that referenced this pull request Jan 3, 2021
- `Softplus` is added in 12/10/2020 from this #7089
- However, I see that there were `SoftPlus` (not the P is in capital) was already in.
According to [Onnx spec](https://github.com/onnx/onnx/blob/master/docs/Operators.md), it is `Softplus` not `SoftPlus`.
tkonolige pushed a commit to tkonolige/incubator-tvm that referenced this pull request Jan 11, 2021
- `Softplus` is added in 12/10/2020 from this apache#7089
- However, I see that there were `SoftPlus` (not the P is in capital) was already in.
According to [Onnx spec](https://github.com/onnx/onnx/blob/master/docs/Operators.md), it is `Softplus` not `SoftPlus`.
TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Jan 20, 2021
TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Jan 20, 2021
- `Softplus` is added in 12/10/2020 from this apache#7089
- However, I see that there were `SoftPlus` (not the P is in capital) was already in.
According to [Onnx spec](https://github.com/onnx/onnx/blob/master/docs/Operators.md), it is `Softplus` not `SoftPlus`.
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jan 21, 2021
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jan 21, 2021
- `Softplus` is added in 12/10/2020 from this apache#7089
- However, I see that there were `SoftPlus` (not the P is in capital) was already in.
According to [Onnx spec](https://github.com/onnx/onnx/blob/master/docs/Operators.md), it is `Softplus` not `SoftPlus`.
electriclilies pushed a commit to electriclilies/tvm that referenced this pull request Feb 18, 2021
electriclilies pushed a commit to electriclilies/tvm that referenced this pull request Feb 18, 2021
- `Softplus` is added in 12/10/2020 from this apache#7089
- However, I see that there were `SoftPlus` (not the P is in capital) was already in.
According to [Onnx spec](https://github.com/onnx/onnx/blob/master/docs/Operators.md), it is `Softplus` not `SoftPlus`.
@jwfromm jwfromm deleted the onnx_softplus branch April 12, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants