-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[CI] Add ACL to the CI for AArch64 #7122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add testing for ACL to the CI for AArch64. A PR follows to add this to the Jenkinsfile once the docker changes land. We also need a separate script to run the tests as the full integration tests are currently broken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM to the dockerfile and build config. I expect the follow-up PR would also enable USE_ARM_COMPUTE_LIB_GRAPH_RUNTIME to cover ACL runtime unit tests.
On the other hand, I don't think we need to add a new task script for ACL. The current Jenkinsfile already covers the ACL unit test in L280 (currently comment out). Specifically, task_python_integration.sh covers all the unit tests under tests/python/contrib, including ACL tests. As a result, I would prefer to bring L280 back in the Jenkinsfile to enable all the tests.
Note: Docker image has to be updated after this PR. cc @tqchen
That is the next step once this is working .Turning that on probably also needs a bit of tweaking in the infra for the tests which I'll try and fix up next. The idea was to get the docker changes in and the testing on par with what happens with the other pipeline but natively.
As I indicated in the covering letter, turning on task_python_integration.sh was failing in my test run with failures with tolerances that I suspect will need more time than I have this side of the holidays. It also means we can get quicker to first getting ACL runtime tests in the CI first.
regards |
I see. Thanks for the clarification.
I must be missing the description before. Then it makes sense to me to have a separate script first until |
Thanks for the swift review. Yes , sorry I don't think I was explicit enough in saying that. Ramana |
Add testing for ACL to the CI for AArch64. A PR follows to add this to the Jenkinsfile once the docker changes land. We also need a separate script to run the tests as the full integration tests are currently broken.
Add testing for ACL to the CI for AArch64. A PR follows to add this to the Jenkinsfile once the docker changes land. We also need a separate script to run the tests as the full integration tests are currently broken.
Add testing for ACL to the CI for AArch64. A PR follows to add this to the Jenkinsfile once the docker changes land. We also need a separate script to run the tests as the full integration tests are currently broken.
Add testing for ACL to the CI for AArch64. A PR follows to add this to the Jenkinsfile once the docker changes land. We also need a separate script to run the tests as the full integration tests are currently broken.
Add testing for ACL to the CI for AArch64. A PR follows
to add this to the Jenkinsfile once the docker changes land.
We also need a separate script to run the tests as the full
python integration tests are currently broken.
[I've tried this on an AArch64 Linux machine and it appears to
work ok.]
I think we'll need to bake a new docker image before the
jenkins file changes land.
@zhiics @comaniac @lhutton1