[Relay] Add fast_softmax #7163
Merged
[Relay] Add fast_softmax #7163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
junrushao
reviewed
Dec 24, 2020
Member
junrushao
left a comment
junrushao
left a comment
There was a problem hiding this comment.
The implementation looks good overall.
Member
|
The impl is good, I was just wondering if the fast softmax is biased or not? |
junrushao
approved these changes
Dec 25, 2020
tkonolige
pushed a commit
to tkonolige/incubator-tvm
that referenced
this pull request
Jan 11, 2021
* [Relay] Add fast_softmax * fix * fix
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Jan 20, 2021
* [Relay] Add fast_softmax * fix * fix
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jan 21, 2021
* [Relay] Add fast_softmax * fix * fix
electriclilies
pushed a commit
to electriclilies/tvm
that referenced
this pull request
Feb 18, 2021
* [Relay] Add fast_softmax * fix * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an exponent operation in softmax. We can use
fast_expfrom #4790 to accelerate it.This pr adds a new op
topi.nn.fast_softmaxto use this optimization.I don't have a manual schedule for it, so this op should only be used together with auto-scheduler. I don't add it to relay's FastMath pass, because other people might use FastMath pass without auto-scheduler.
To use this op, users can create a new relay pass to do the op substitution.