Skip to content

[TOPI] Treat undefined elements as constants in Array #7232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
comaniac merged 4 commits into from
Jan 9, 2021
Merged

[TOPI] Treat undefined elements as constants in Array #7232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
274e4a6
[TOPI] Treat undefined elements as constants in Array
comaniac Jan 8, 2021
cbd3e9a
Add a checker
comaniac Jan 8, 2021
d052cb1
fix
comaniac Jan 8, 2021
58ae831
add test case
comaniac Jan 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions include/tvm/topi/detail/constant_utils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ using namespace tvm::te;
inline bool IsConstInt(PrimExpr expr) { return expr->IsInstance<tvm::tir::IntImmNode>(); }

/*!
* \brief Test whether the given Array has every element as constant integer
* \brief Test whether the given Array has every element as constant integer.
* Undefined elements are also treat as constants.
*
* \param array the array to query
*
Expand All @@ -57,7 +58,7 @@ inline bool IsConstInt(PrimExpr expr) { return expr->IsInstance<tvm::tir::IntImm
inline bool IsConstIntArray(Array<PrimExpr> array) {
bool is_const_int = true;
for (auto const& elem : array) {
is_const_int &= elem->IsInstance<tvm::tir::IntImmNode>();
is_const_int &= !elem.defined() || elem->IsInstance<tvm::tir::IntImmNode>();
}
return is_const_int;
}
Expand Down
1 change: 1 addition & 0 deletions include/tvm/topi/transform.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,6 +612,7 @@ inline Tensor strided_slice(const Tensor& x, const Array<PrimExpr>& begin,

Array<PrimExpr> out_shape;
if (!is_static) {
ICHECK_EQ(strides.size(), src_tensor_dim);
for (size_t i = 0; i < src_tensor_dim; ++i) {
out_shape.push_back(indexdiv(end[i] - begin[i], strides[i]));
}
Expand Down
1 change: 1 addition & 0 deletions tests/python/topi/python/test_topi_transform.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -817,6 +817,7 @@ def test_strided_slice():
verify_strided_slice((3, 4, 3), [1, -1, 0], [2, -3, 3], [1, -1, 1])
verify_strided_slice((3, 4, 3), [1, 1, 0], [4, 4, 3])
verify_strided_slice((3, 4, 3), [0, 2, 0], [1, 2, 3])
verify_strided_slice((3, 4, 3), [0, 0, 0], [None, None, None])


@tvm.testing.uses_gpu
Expand Down