[Relay][Frontend][Onnx] Set default value of p in LpPool as 2 #7242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
|
Can you add a test that would trigger the error? Once that's included in this PR it should be good to go. Thanks for identifying and fixing this. |
Member
Contributor
Author
|
Hi @jwfromm , I added a testcase. |
jwfromm
approved these changes
Mar 2, 2021
Contributor
jwfromm
left a comment
jwfromm
left a comment
There was a problem hiding this comment.
LGTM, thanks for this fix!
Contributor
|
Looks like you just need to format the test file and we can merge. |
Contributor
Author
|
Hi @jwfromm , what do you mean that |
Member
|
run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #7241