[BYOC][ACL] removed ACL 20.05 limitations #7251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
d-smirnov
force-pushed
the
acl-no-padding
branch
2 times, most recently
from
8779457 to
6e9b18d
Compare
Removed checks for padding in according with changes in ACL 20.11 *ACL stands for "Compute Library for the Arm® Architecture"
d-smirnov
force-pushed
the
acl-no-padding
branch
from
6e9b18d to
c8fe781
Compare
mbaret
reviewed
Jan 18, 2021
Contributor
mbaret
left a comment
mbaret
left a comment
There was a problem hiding this comment.
This looks OK, but a question on what's happened with the tests. It seems like you've removed the check for the number of ACL partitions - is this because previously some tests wouldn't offload due to the padding restriction but now they always do?
Contributor
Author
|
Correct. Tests were restored to initial state (before padding limitations). Now each test always resulted to ACL-partitioned IR so there is no need to have this variations. |
Contributor
Author
|
Ping. How we can make a progress here? |
Contributor
|
Thanks @d-smirnov |
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Jan 20, 2021
Removed checks for padding in according with changes in ACL 20.11 *ACL stands for "Compute Library for the Arm® Architecture"
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jan 21, 2021
Removed checks for padding in according with changes in ACL 20.11 *ACL stands for "Compute Library for the Arm® Architecture"
electriclilies
pushed a commit
to electriclilies/tvm
that referenced
this pull request
Feb 18, 2021
Removed checks for padding in according with changes in ACL 20.11 *ACL stands for "Compute Library for the Arm® Architecture"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes checks for padding in according with changes in ACL 20.11 which currently does not require padded data.