[BYOC][Verilator] add support to dynamically load hardware library #7286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@tqchen I'd love some input on this if you have time to review |
liangfu
approved these changes
Jan 22, 2021
liangfu
reviewed
Jan 22, 2021
| return mod | ||
|
|
||
|
|
||
| def verilator_app_path(): |
Member
There was a problem hiding this comment.
I don't think it's actually running in the CI (see https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-7286/6/pipeline/255#step-340-log-91), would be better if we could enable testing this.
Member
Author
There was a problem hiding this comment.
Hey @liangfu
Yeah that is the plan, once we merge this. The idea is to finally update that PR that we have open for CI.
tmoreau89
approved these changes
Jan 22, 2021
Contributor
tmoreau89
left a comment
tmoreau89
left a comment
There was a problem hiding this comment.
Love the new dynamic load feature, the code below looks very clean.
with tvm.transform.PassContext(
opt_level=3, config={"relay.ext.verilator.options": {"lib": lib}}
):
LGTM
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 11, 2021
…pache#7286) * add files * remove import * remove os import * reorder header * fix header order cpplint * lint fix
electriclilies
pushed a commit
to electriclilies/tvm
that referenced
this pull request
Feb 18, 2021
…pache#7286) * add files * remove import * remove os import * reorder header * fix header order cpplint * lint fix
Lokiiiiii
pushed a commit
to Lokiiiiii/tvm
that referenced
this pull request
Mar 2, 2021
…pache#7286) * add files * remove import * remove os import * reorder header * fix header order cpplint * lint fix
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2021
…pache#7286) * add files * remove import * remove os import * reorder header * fix header order cpplint * lint fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@liangfu @tmoreau89