[PatternLang] Add a relay LetPattern #7332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrookhart
force-pushed
the
let_pattern
branch
from
f5662b3 to
b38f5b5
Compare
comaniac
approved these changes
Jan 23, 2021
Contributor
comaniac
left a comment
comaniac
left a comment
There was a problem hiding this comment.
LGTM. Just a few typos.
Member
|
I wonder, do we need to match against the let bound variable? Isn't it always |
Contributor
Author
|
@masahi I agree the Expr will always be a var, but I wanted to let users match on more complicated attributes like name/dtype/shape/etc, so I left it a general in pattern |
masahi
approved these changes
Jan 23, 2021
Co-authored-by: Cody Yu <comaniac0422@gmail.com>
Co-authored-by: Cody Yu <comaniac0422@gmail.com>
Member
|
Thanks @mbrookhart @comaniac |
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 11, 2021
* Add a relay LetPattern * fix If copy Co-authored-by: Cody Yu <comaniac0422@gmail.com> * fix If copy Co-authored-by: Cody Yu <comaniac0422@gmail.com> Co-authored-by: Cody Yu <comaniac0422@gmail.com>
electriclilies
pushed a commit
to electriclilies/tvm
that referenced
this pull request
Feb 18, 2021
* Add a relay LetPattern * fix If copy Co-authored-by: Cody Yu <comaniac0422@gmail.com> * fix If copy Co-authored-by: Cody Yu <comaniac0422@gmail.com> Co-authored-by: Cody Yu <comaniac0422@gmail.com>
Lokiiiiii
pushed a commit
to Lokiiiiii/tvm
that referenced
this pull request
Mar 2, 2021
* Add a relay LetPattern * fix If copy Co-authored-by: Cody Yu <comaniac0422@gmail.com> * fix If copy Co-authored-by: Cody Yu <comaniac0422@gmail.com> Co-authored-by: Cody Yu <comaniac0422@gmail.com>
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2021
* Add a relay LetPattern * fix If copy Co-authored-by: Cody Yu <comaniac0422@gmail.com> * fix If copy Co-authored-by: Cody Yu <comaniac0422@gmail.com> Co-authored-by: Cody Yu <comaniac0422@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found myself needing a Let pattern for some object detection work. Thanks for taking a look!