Skip to content

Conversation

@areusch
Copy link
Contributor

@areusch areusch commented Feb 1, 2021

  • Make build/standalone_crt available to CI unit tests.
  • We could do this with stash but it's complex because we would need
    to use wildcards. Instead, rebuild standalone_crt source tree before testing.

Jenkinsfile Outdated
timeout(time: max_time, unit: 'MINUTES') {
sh "${docker_run} ${ci_gpu} ./tests/scripts/task_ci_python_setup.sh"
sh "${docker_run} ${ci_gpu} ./tests/scripts/task_config_build_gpu.sh"
sh "${docker_run} ${ci_gpu} ./tests/scripts/task_build.sh build standalone_crt"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this trigger rebuild of libtvm? or simply just standalone_crt?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok resolved per our discussion. we will not explicitly introduce a separate build step here; instead we will add this build to tests/scripts/task_ci_setup.sh, which was previously tests/scripts/task_ci_python_setup.sh

hanke580 pushed a commit to hanke580/incubator-tvm that referenced this pull request Feb 2, 2021
…ORT_PACKED_FUNC macros in packed_func.h. This is a patch PR for apache#7388. (apache#7343)

Co-authored-by: JC Li <jinli@nvidia.com>
 * Make build/standalone_crt available to CI unit tests.
 * We could do this with stash but it's complex because we would need
   to use wildcards. Instead, rebuild standalone_crt source tree before testing.
@areusch
Copy link
Contributor Author

areusch commented Feb 3, 2021

@tqchen good to merge now?

@tqchen
Copy link
Member

tqchen commented Feb 5, 2021

@areusch please resolve merge conflict

@areusch
Copy link
Contributor Author

areusch commented Feb 8, 2021

@tqchen done

@tqchen tqchen merged commit 5103bb6 into apache:main Feb 8, 2021
alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 11, 2021
…ORT_PACKED_FUNC macros in packed_func.h. This is a patch PR for apache#7388. (apache#7343)

Co-authored-by: JC Li <jinli@nvidia.com>
alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 11, 2021
electriclilies pushed a commit to electriclilies/tvm that referenced this pull request Feb 18, 2021
…ORT_PACKED_FUNC macros in packed_func.h. This is a patch PR for apache#7388. (apache#7343)

Co-authored-by: JC Li <jinli@nvidia.com>
Lokiiiiii pushed a commit to Lokiiiiii/tvm that referenced this pull request Mar 2, 2021
…ORT_PACKED_FUNC macros in packed_func.h. This is a patch PR for apache#7388. (apache#7343)

Co-authored-by: JC Li <jinli@nvidia.com>
Lokiiiiii pushed a commit to Lokiiiiii/tvm that referenced this pull request Mar 2, 2021
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Mar 2, 2021
…ORT_PACKED_FUNC macros in packed_func.h. This is a patch PR for apache#7388. (apache#7343)

Co-authored-by: JC Li <jinli@nvidia.com>
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants