fix:getcwd not work on android platform #7390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
approved these changes
Mar 10, 2021
Member
|
Thank you @fantasyRqg ! |
csullivan
reviewed
Mar 16, 2021
Comment on lines
+89
to
+95
| #if defined(ANDROID) || defined(__ANDROID__) | ||
| char cwd[PATH_MAX]; | ||
| auto cmdline = fopen("/proc/self/cmdline", "r"); | ||
| fread(cwd, 1, sizeof(cwd), cmdline); | ||
| fclose(cmdline); | ||
| base_ = "/data/data/" + std::string(cwd) + "/cache/rpc"; | ||
| #elif !defined(_WIN32) |
Contributor
There was a problem hiding this comment.
This change has the effect of now requiring a user to provide a target path to RPCSession.upload(..., target=path), when running from /data/local/tmp for example. Without providing the target path, the /data/data prefix is always prepended resulting in errors like:
Check failed: !fs.fail() == false: Cannot open /data/data//data/local/tmp/tvm_rpc/cache/rpc/dev_lib_cl.so
Member
There was a problem hiding this comment.
@csullivan great catch, can you send a new PR to fix this problem?
Contributor
There was a problem hiding this comment.
Absolutely, please allow me some time.
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
* fix:getcwd not work on android platform * replace `exit()` with `_exit()` on subprocess in `cpp_rpc` Co-authored-by: rqg <ranqingguo318@gmail.com>
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
* fix:getcwd not work on android platform * replace `exit()` with `_exit()` on subprocess in `cpp_rpc` Co-authored-by: rqg <ranqingguo318@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getcwdnot work on android platform , just get"\"exit()with_exit()on subprocess incpp_rpc@vinx13 @tqchen