Many fixes to get unit tests passing on Windows. #7431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
requested changes
Feb 10, 2021
python/tvm/contrib/cc.py
Outdated
| def _windows_compile(output, objects, options): | ||
| cmd = ["clang"] | ||
| cmd += ["-O2", "-flto=full", "-fuse-ld=lld-link"] | ||
| cmd += ["-O2", "-v", "-fvisibility=default", "-export-all-symbols"] |
Member
There was a problem hiding this comment.
Can we check if we need -export-all-symbols after #6698? I believe we should have marked the life scopes correctly.
Contributor
Author
There was a problem hiding this comment.
Yes, there are some debug flags in there too, -v. That line needs to be cleaned up.
Member
There was a problem hiding this comment.
OK, thanks, please add a comment about the need of debug flags there.
Contributor
Author
There was a problem hiding this comment.
The current code in the PR only has the flag -O2. The other flags are not required.
CUDA tests passing on Windows.
CUDA tests passing on Windows.
tqchen
approved these changes
Feb 25, 2021
Member
|
Thanks @rkimball ! |
Lokiiiiii
pushed a commit
to Lokiiiiii/tvm
that referenced
this pull request
Mar 2, 2021
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not everything passes, but much more passes than used to.