[Relay][Quantization] Fix Bug Which Cause Negative Left Shift Op #7432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Please @ZihengJiang, @vinx13 help to review, thanks. |
vinx13
approved these changes
Feb 10, 2021
Member
|
How about adding one unit testing? |
Member
|
Merging this in as the fix is quite obvious. @Johnson9009 It would be great if you can send a followup test case that covers the regression. |
Contributor
Author
|
@tqchen @FrozenGene Sorry for late reply because of lots of work, yes it is great to add a test case in regression, I will try to add one as soon as possible. |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very easy to understand bug, maybe the original commiter forgot to add the negative sign in the "else" branch, it will cause the "nbit" of "left_shift" operator be a negative number, e.g., "left_shift(%50, -1)".