[Relay][Frontend][Onnx] Fix GEMM converter when C is not a parameter. #7509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@mbrookhart @xutianming @masahi can one of you take a look at this PR? |
Lokiiiiii
pushed a commit
to Lokiiiiii/tvm
that referenced
this pull request
Mar 2, 2021
…apache#7509) * Fix onnx gemm with non parameter C. * Add gemm tests for C. * Fix formatting.
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2021
…apache#7509) * Fix onnx gemm with non parameter C. * Add gemm tests for C. * Fix formatting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change made to the Onnx gemm converter in #7489 assumes that the value of C will always be a parameter. When it is a constant or an expression, the special case handling will fail. This very tiny PR makes the handling of C more general and adds test cases that would otherwise fail.