[RELAY] Modify some passes to not stack overflow on many lets. #7558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passes modified: - inline primitives - dead code - lambda lift
tkonolige
force-pushed
the
nonrecursive_let
branch
from
5570972 to
f305496
Compare
mbrookhart
approved these changes
Mar 1, 2021
Contributor
mbrookhart
left a comment
mbrookhart
left a comment
There was a problem hiding this comment.
Nitpick for performance, otherwise LGTM
Contributor
|
Oh, looks like it's not passing dead_code tests. |
zhiics
approved these changes
Mar 3, 2021
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
…e#7558) * [RELAY] Modify some passes to not stack overflow on many lets. Passes modified: - inline primitives - dead code - lambda lift * one fix * small fix * .at -> [] * fix
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
…e#7558) * [RELAY] Modify some passes to not stack overflow on many lets. Passes modified: - inline primitives - dead code - lambda lift * one fix * small fix * .at -> [] * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've refactored some recursion on let nodes to be iterative. This fixes stack overflows in big models on #7153.
Passes modified:
@mbrookhart @zhiics @jroesch