Skip to content

Conversation

@leeexyz
Copy link
Contributor

@leeexyz leeexyz commented Mar 5, 2021

Hi Community,

When I try to use the auto inline functions, I found that one for element-wise is not working due to the wrong VisitExpr_, it should be ProducerLoadNode not CallNode. And I also implement the broadcast one by simply checking the tag, cause ops in Topi has the specified tag.

@comaniac @ZihengJiang @tqchen Please help to review, thanks!

Copy link
Contributor

@jcf94 jcf94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@leeexyz leeexyz requested a review from jcf94 March 8, 2021 06:19
@leeexyz leeexyz requested a review from comaniac March 8, 2021 07:35
@comaniac comaniac merged commit cc7f8dc into apache:main Mar 8, 2021
@comaniac
Copy link
Contributor

comaniac commented Mar 8, 2021

Thanks @leeexyz @jcf94

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request May 6, 2021
…pache#7602)

* [TE] Fix bug in AutoInlineElemWise and implement AutoInlineBroadcast

* [TE] Add AutoInlineBroadcast API to schedule_pass.h
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request May 11, 2021
…pache#7602)

* [TE] Fix bug in AutoInlineElemWise and implement AutoInlineBroadcast

* [TE] Add AutoInlineBroadcast API to schedule_pass.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants