Skip to content

[OpenCL] Skip opencl memory operations on empty tensors #7672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mbrookhart wants to merge 1 commit into from
Closed

[OpenCL] Skip opencl memory operations on empty tensors #7672

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/runtime/opencl/opencl_device_api.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,10 @@ void* OpenCLWorkspace::AllocDataSpace(TVMContext ctx, size_t size, size_t alignm
this->Init();
ICHECK(context != nullptr) << "No OpenCL device";
cl_int err_code;
if (size == 0) {
// opencl malloc API can't handle an empty tensor, so we skip it
return nullptr;
}
cl_mem mptr = clCreateBuffer(this->context, CL_MEM_READ_WRITE, size, nullptr, &err_code);
OPENCL_CHECK_ERROR(err_code);
return mptr;
Expand All @@ -141,6 +145,10 @@ void OpenCLWorkspace::CopyDataFromTo(const void* from, size_t from_offset, void*
TVMStreamHandle stream) {
this->Init();
ICHECK(stream == nullptr);
if (size == 0) {
// don't do anything for empty buffers
return;
}
if (IsOpenCLDevice(ctx_from) && IsOpenCLDevice(ctx_to)) {
OPENCL_CALL(clEnqueueCopyBuffer(this->GetQueue(ctx_to),
static_cast<cl_mem>((void*)from), // NOLINT(*)
Expand Down