Skip to content

Revert "[ONNX][NMS] init the NMS output tensor with 1s and then slice them away after the loop" #7673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mbrookhart wants to merge 1 commit into from
Closed

Revert "[ONNX][NMS] init the NMS output tensor with 1s and then slice them away after the loop" #7673

mbrookhart wants to merge 1 commit into from

Conversation

@mbrookhart
Copy link
Contributor

@mbrookhart mbrookhart commented Mar 16, 2021

Reverts #7666 in favor of #7672

@mbrookhart
Copy link
Contributor Author

mbrookhart commented Mar 16, 2021

cc @masahi

@masahi masahi self-assigned this Mar 16, 2021
@mbrookhart
Copy link
Contributor Author

mbrookhart commented Mar 26, 2021

I'll reopen this manually, this hit a flaky unit test.

@mbrookhart mbrookhart closed this Mar 26, 2021
@mbrookhart mbrookhart deleted the revert-7666-onnx_nms_empty_init branch March 26, 2021 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@masahi masahi

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mbrookhart @masahi