[Relay][QNN] Relax simulated qnn tests to prevent flakiness. #7684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@masahi can you take a look? |
masahi
approved these changes
Mar 18, 2021
Member
|
Thanks @jwfromm |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
…7684) * Relax simulated qnn tests to prevent flakiness. * Change name of helper to make pytest happy.
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
…7684) * Relax simulated qnn tests to prevent flakiness. * Change name of helper to make pytest happy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous PR (#7613) introduced some flaky tests due to a low change of GPU arithmetic causing a rounding error, as noted in #7652. This small PR adds a little wiggle room in the asserts that should prevent such failures going forward.